minor bug fixes

paulosabayomi · Mar 7, 2024 · f565742 · f565742
1 parent f4963ca
commit f565742
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
-## 1.1.5 (2024-03-05)
+## 1.1.6 (2024-03-06)
+
+- Fix: An undefined variable bug caused by the method that returns the attached form field as an HTML element or undefined if not provided.
+
+## 1.1.5 (2024-03-06)
 
 - Fix: Typescript bugs caused by not setting optional options as optional.
 

diff --git a/core/custupCore.d.ts b/core/custupCore.d.ts
@@ -889,7 +889,7 @@ export default class CustUpCore extends EventTarget {
      * @method upload - the method to upload file to the endpoint
      * @param {string | undefined} file_id - the id of the file to upload in the case of a single file, all the files will be uploaded serially if not provided
      */
-    upload(file_id: string | undefined): void;
+    upload(file_id?: string | undefined): void;
     /**
      * @method retry_upload - to retry uploading a file
      * @param {string} file_id - the id of the file to retry

diff --git a/core/custupCore.d.ts.map b/core/custupCore.d.ts.map
diff --git a/core/custupCore.js b/core/custupCore.js
@@ -1904,7 +1904,7 @@ export default class CustUpCore extends EventTarget {
         attached_files.map(file => _class.file_upload_form_data.append(_class.options.file_upload_settings.files_field_name, file))
 
         const all_files = [...this.selectedFiles, ...attached_files];
-        const beforeUploadStartCheck = this.triggerEvent('upload_beforeStart', {files: all_files, formData: _class.file_upload_form_data, form: form_field})
+        const beforeUploadStartCheck = this.triggerEvent('upload_beforeStart', {files: all_files, formData: _class.file_upload_form_data, form: this.get_attached_form_field()})
         if (!beforeUploadStartCheck) {
             this.show_message("Please check that all requirements have been satisfied", "error");
             return;
@@ -1975,7 +1975,7 @@ export default class CustUpCore extends EventTarget {
      * @private @method get_attached_form_field
      */
     get_attached_form_field () {
-        return !_class.options.file_upload_settings.form_field ? undefined : document.querySelector(_class.options.file_upload_settings.form_field);
+        return !this.options.file_upload_settings.form_field ? undefined : document.querySelector(this.options.file_upload_settings.form_field);
     }
 
     /**
@@ -2144,7 +2144,7 @@ export default class CustUpCore extends EventTarget {
      * @method upload - the method to upload file to the endpoint
      * @param {string | undefined} file_id - the id of the file to upload in the case of a single file, all the files will be uploaded serially if not provided
      */
-    upload (file_id) {
+    upload (file_id=undefined) {
         const file = this.selectedFiles.find(fl => fl.id == file_id)
         this.fileUploadHandler(file);
     }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "custup",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "description": "Highly customisable file upload library with zero dependencies",
   "main": "src/custup.min.js",
   "scripts": {