[1.x] Config by value type. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
============================================
- Coverage 88.77% 88.62% -0.16%
- Complexity 183 186 +3
============================================
Files 22 22
Lines 588 589 +1
============================================
Hits 522 522
- Misses 66 67 +1 ☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
b820790
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a5365c12.orchestration.pages.dev |
| Branch Preview URL: | https://enhancement-36-config-by-val.orchestration.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🤖
Allows multiple mays to specify your service config.
You may either specify a string value pointing to another config file, or define your config in an array withing your orchestration config.
Any background context you would like to provide? 🚧
The reasoning behind this is when you utilize the database driver, having a separate config file for that service is unnecessary.
Does this relate to any issue? 🔗
Closes #36.