Add multiple language support for Standard & Advanced Integration #152
Conversation
feat: add backend and frontend implementations feat: update README.md feat: added code for standard integration chore: delete full stack code and update package names
…new-lanugage Feature/devcontainer support for new lanugage
| using Microsoft.Extensions.Hosting; | ||
| using Newtonsoft.Json; | ||
|
|
||
| namespace PayPalAdvancedIntegration |
There was a problem hiding this comment.
Is there a specific version of C#/.NET you're targeting here? I think it's probably more common to use a simple namespace declaration namespace PayPalAdvancedIntegration; instead of enclosing the whole file in curly braces.
There was a problem hiding this comment.
We are targeting v8.0. I'll remove the curly braces
There was a problem hiding this comment.
Using file scoped namespace now
| @@ -0,0 +1,14 @@ | |||
| # How to Contribute | |||
There was a problem hiding this comment.
It doesn't look like this example uses Slim, was this pulled over from a previous/different example? We can probably just remove the whole thing.
There was a problem hiding this comment.
Yes we were using Slim earlier and we had found some issues with it. I'll remove this file.
| @@ -0,0 +1,18 @@ | |||
| version: '3.7' | |||
There was a problem hiding this comment.
I don't see that other languages have a docker/compose file. Is this needed?
There was a problem hiding this comment.
No, I'll remove it
| @@ -0,0 +1,14 @@ | |||
| # How to Contribute | |||
There was a problem hiding this comment.
Same as advanced example, do we need this?
There was a problem hiding this comment.
Explained earlier. I'll remove this.
| @@ -0,0 +1,18 @@ | |||
| version: '3.7' | |||
There was a problem hiding this comment.
Same as advanced example, do we need this?
- Rename backend, frontend folders to server, client respectively - Remove SlimPHP contribution guidelines - Remove docker-compose.yml from php - Use file scoped namespace for dotnet
feat: add backend and frontend implementations
feat: update README.md
feat: added code for standard integration
chore: delete full stack code and update package names