fix: simplify handling of deviceID #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seavenly
reviewed
Aug 24, 2023
src/components/message/Message.js
Outdated
| ts: getTsCookieFromStorage(), | ||
| deviceID: getOrCreateStorageID(), |
There was a problem hiding this comment.
If we're no longer pulling the deviceID in the zoid component onReady hooks for the message or modal does this still serve any purpose? If not can this and other instances for the message and modal code just be completely removed if the treatments component is supposed to be the only frame making that communication?
Seavenly
approved these changes
Aug 28, 2023
paypal-rosman
approved these changes
Aug 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
## [1.47.0](v1.46.1...v1.47.0) (2023-08-29) ### Features * Create Messaging function to send back current date for US Pi4 Preapproval modals in XO ([#967](#967)) ([380656c](380656c)) * native modal communication ([#851](#851)) ([1d30e05](1d30e05)) * runtime functionality for easier development testing ([#972](#972)) ([0bc86fe](0bc86fe)) * update nominal rate and APR in DE LT modal legal disclosure ([#974](#974)) ([9e937ba](9e937ba)) ### Bug Fixes * simplify handling of deviceID ([#975](#975)) ([42012c4](42012c4))
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
N/A
Testing instructions
Need to consider all possible states of deviceID in localStorage and different integrations that may be currently relying on the way that has been populated previously