-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DTPPSDK-1319]Add getExperimentation() #163
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 87.70% 87.83% +0.12%
==========================================
Files 20 20
Lines 480 485 +5
Branches 40 40
==========================================
+ Hits 421 426 +5
Misses 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Xuan! For this PR, we should only need the getExperimentation()
function & the related tests. We will not need the changes to logger 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
This reverts commit e5b1c42.
Got
from global, then inside getExperimentation(), format it and return