Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTPPSDK-1319]Add getExperimentation() #163

Merged
merged 10 commits into from
Aug 9, 2023
Merged

[DTPPSDK-1319]Add getExperimentation() #163

merged 10 commits into from
Aug 9, 2023

Conversation

xuanwan05
Copy link
Contributor

@xuanwan05 xuanwan05 commented Aug 3, 2023

Got

 __EXPERIMENTATION__: {
    __EXPERIENCE__: "1234, 4321";
    __TREATMENT__: "8765,7890";
  }

from global, then inside getExperimentation(), format it and return

experimation:{
    experience: "1234, 4321",
    treatment: "8765,7890"
}

@xuanwan05 xuanwan05 requested a review from a team as a code owner August 3, 2023 18:20
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (048b2c7) 87.70% compared to head (e5b1c42) 87.83%.

❗ Current head e5b1c42 differs from pull request most recent head 4235bd8. Consider uploading reports for the commit 4235bd8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   87.70%   87.83%   +0.12%     
==========================================
  Files          20       20              
  Lines         480      485       +5     
  Branches       40       40              
==========================================
+ Hits          421      426       +5     
  Misses         59       59              
Flag Coverage Δ
client 83.79% <100.00%> (+0.22%) ⬆️
server 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/types.js 100.00% <ø> (ø)
src/global.js 97.36% <100.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@spencersablan spencersablan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Xuan! For this PR, we should only need the getExperimentation() function & the related tests. We will not need the changes to logger 😅

@xuanwan05 xuanwan05 changed the title [DTPPSDK-1319]pass experimentation to url params [DTPPSDK-1319]Add getExperimentation() Aug 4, 2023
src/declarations.js Outdated Show resolved Hide resolved
src/global.js Outdated Show resolved Hide resolved
test/client/global.js Show resolved Hide resolved
Copy link
Contributor

@ravishekhar ravishekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@xuanwan05 xuanwan05 merged commit 0d1f467 into main Aug 9, 2023
1 check passed
@wsbrunson wsbrunson deleted the cookie-exp branch April 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants