Add SDK token for PayPal domain #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethmv
force-pushed
the
add-sdk-token
branch
from
83593d9
to
c33c00a
Compare
wsbrunson
approved these changes
Dec 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 87.93% 87.75% -0.18%
==========================================
Files 20 20
Lines 489 490 +1
Branches 40 40
==========================================
Hits 430 430
- Misses 59 60 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wsbrunson
reviewed
Dec 5, 2023
src/script.js
Outdated
| @@ -338,6 +339,10 @@ export function getUserExperienceFlow(): ?string { | |||
| return getSDKAttribute(SDK_SETTINGS.USER_EXPERIENCE_FLOW); | |||
| } | |||
|
|
|||
| export function getSDKToken(): ?string { | |||
| return isPayPalDomain() ? getSDKAttribute(SDK_SETTINGS.SDK_TOKEN) : ""; | |||
There was a problem hiding this comment.
we should actually remove this check so that the axo project can start using this value too. They are about to go live with a merchant
There was a problem hiding this comment.
Makes sense, I'll get this removed
elizabethmv
force-pushed
the
add-sdk-token
branch
from
0f1f54c
to
c75e1aa
Compare
wsbrunson
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricting to PayPal domains for now, we will remove/add merchant domains in phases for Alpha/GA