DPoP: use RS256 instead of ES256 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 73.66% 73.68% +0.02%
==========================================
Files 23 23
Lines 2035 2037 +2
Branches 240 240
==========================================
+ Hits 1499 1501 +2
Misses 526 526
Partials 10 10 ☔ View full report in Codecov by Sentry. |
nbierdeman
approved these changes
Mar 1, 2024
Comment on lines
+43
to
+44
| hash: "SHA-256", | ||
| name: "RSASSA-PKCS1-v1_5", |
wsbrunson
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
RS256signing and verification algorithm instead ofES256. This change was requested by the identity team who will be usingRS256for the signature verification.example jwt