Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Limit thread focus loop by time, not threads. #1519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Limit thread focus loop by time, not threads. #1519

wants to merge 1 commit into from

Commits on Jan 26, 2022

  1. Limit thread focus loop by time, not threads. 

    Resolve pazz#1518. The problem that search_threads_rebuild_limit tries to
solve is UI responsiveness, so the relevant thing to limit is time, not
loops.

Next steps if this approach is accepted:
- Must: Deprecate search_threads_rebuild_limit -- Has a process been
developed for option deprecation/removal?
- Maybe: Add a configuration option for the timeout. Personally I don't
think this is necessary because unlike the previous approach this is not
relative to the user's processor and inbox size. It's always something
that can be added if a need arises.
- Maybe: Execute consume_pipe_until in a separate thread, sleep for the
timeout, and then kill the thread. This would eliminate the
wasteful clock checking every loop but I'm doubtful it's actually more
performant.
    @ryneeverett
    ryneeverett committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    17acf2a View commit details
    Browse the repository at this point in the history