Fixes for Issue #146

[TheSin-]

This is all very very untested, I've only had the time to test this on darwin with fink installed php, I have removed php to watch it fail but that is all thus far, much more testing is required and this is just a quick attempt I'm sure this could be expanded to be more verbose and robust.

[pbiggar]

Do you have a linux VM you can test it in? If it compilses there then it should be fine.

[TheSin-]

I have several debian boxes that I will test on as soon as I can, day is over here so likely give it a shot tomorrow.

[TheSin-]

As it turns out this patch has LOTS of build time issues, I'll resubmit an other again darwin, and work on linux tomorrow if anything is required

TS
http://www.southofheaven.org/
Life begins and ends with chaos, live between the chaos!

On 2012-06-19, at 3:11 PM, Paul Biggar wrote:

Do you have a linux VM you can test it in?

---

Reply to this email directly or view it on GitHub:
#5 (comment)

[TheSin-]

okay this has been tested from config to runtime on darwin, I'll find time to do the same on linux today and report back

[TheSin-]

it seems that for php5.4 fix (commit 4c655a5) isn't complete, it fixes build time issues but runtime is still very much an issue on php5.4

output from trying to compile

---

info.c: In function ‘initialize_method_call’:
info.c:1084: error: too few arguments to function ‘(*obj)->value.obj.handlers->get_method’
info.c: In function ‘phc_declare_property’:
info.c:1235: warning: passing argument 1 of ‘efree’ discards qualifiers from pointer target type
info.c: In function ‘zif___MAIN_’:
info.c:1751: error: ‘struct ’ has no member named ‘pass_rest_by_reference’
info.c:1847: error: ‘struct ’ has no member named ‘return_reference’
info.c:1862: error: ‘struct ’ has no member named ‘return_reference’
info.c:1940: error: ‘struct ’ has no member named ‘return_reference’
info.c:1955: error: ‘struct ’ has no member named ‘return_reference’
info.c: At top level:
info.c:2004: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘attribute’ before ‘app_functions’
info.c:2012: error: ‘app_functions’ undeclared here (not in a function)
info.c: In function ‘main’:
info.c:2051: warning: useless type name in empty declaration

[pbiggar]

Hey @TheSin-, I know it's 4 years later, but I just tidied up phc, got it compiling on linux and OSX, and have CI builds set up with CircleCI. If you wanted to test this, tidy it up and get it into phc, I'd take that patch.