Address review

pblottiere · Sep 25, 2023 · 0d1e390 · 0d1e390
1 parent d29c219
commit 0d1e390
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/app/qgsmaptoolmovefeature.cpp b/src/app/qgsmaptoolmovefeature.cpp
@@ -244,7 +244,6 @@ void QgsMapToolMoveFeature::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
       }
       case CopyMove:
         QgsFeatureRequest request;
-        qDebug() << mMovedFeatures;
         request.setFilterFids( mMovedFeatures );
         QString errorMsg;
         QString childrenInfoMsg;

diff --git a/src/core/vector/qgsvectorlayertools.cpp b/src/core/vector/qgsvectorlayertools.cpp
@@ -59,6 +59,15 @@ bool QgsVectorLayerTools::copyMoveFeatures( QgsVectorLayer *layer, QgsFeatureReq
     if ( mProject )
     {
       newFeature = QgsVectorLayerUtils::duplicateFeature( layer, f, mProject, duplicateFeatureContext );
+      if ( !newFeature.isValid() )
+      {
+        couldNotWriteCount++;
+        QgsDebugError( QStringLiteral( "Could not add new feature. Original copied feature id: %1" ).arg( f.id() ) );
+      }
+      else
+      {
+        fidList.insert( newFeature.id() );
+      }
 
       const auto duplicateFeatureContextLayers = duplicateFeatureContext.layers();
       for ( QgsVectorLayer *chl : duplicateFeatureContextLayers )
@@ -81,13 +90,16 @@ bool QgsVectorLayerTools::copyMoveFeatures( QgsVectorLayer *layer, QgsFeatureReq
         couldNotWriteCount++;
         QgsDebugError( QStringLiteral( "Could not add new feature. Original copied feature id: %1" ).arg( f.id() ) );
       }
+      else
+      {
+        fidList.insert( newFeature.id() );
+      }
     }
 
     // translate
     if ( newFeature.hasGeometry() )
     {
       QgsGeometry geom = newFeature.geometry();
-      fidList.insert( newFeature.id() );
       if ( topologicalEditing )
       {
         if ( topologicalLayer )