-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect (m,n,k) game + a few minor changes #16
base: master
Are you sure you want to change the base?
Connect (m,n,k) game + a few minor changes #16
Conversation
Hi Lucas, sorry for the delay in getting to these, I've been super busy the past couple of months I'm afraid. Thanks for sticking with this, I'll get to reviewing this once life is slightly less crazy. |
Hi Paul !
Good to hear you. I hope that the important things in life are going right for you.
Don’t mind for my pull request ; it is hobby.
Cheers,
Lucas
|
Hey :) Just wanted to check in and see if you have plans to merge these changes @pbsinclair42? Briefly looking them over they seem very reasonable 👍 |
Konstantin, |
@LucasBorboleta since this repo seems to be inactive I decided to fork it and keep working there. I did add this PR as a patch to my code base. I am using this package in another project so it will be nice if it follows conventions... |
I did get started on my endeavour in this repo and published v2.0.0 pypi package in case anyone is interested :) |
Konstantin, |
Sure :) I added a patch of this PR to the repo so your account is linked with the corresponding commit, but I will mention you in the readme as well as the author of the example :) |
All right ! |
Hi Paul !
I hope things go well for you.
Being in the doubt ( either 1) you are busy with other stuff and that's fine or 2) you are expecting me to rework my branch) I have reworked my branch "LucasBorboleta" in the form of a new branch "LucasBorboleta2" by taking into account (I hope so) your feedback from my former branch.
Lucas