Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect (m,n,k) game + a few minor changes #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LucasBorboleta
Copy link

Hi Paul !

I hope things go well for you.

Being in the doubt ( either 1) you are busy with other stuff and that's fine or 2) you are expecting me to rework my branch) I have reworked my branch "LucasBorboleta" in the form of a new branch "LucasBorboleta2" by taking into account (I hope so) your feedback from my former branch.

Lucas

@pbsinclair42
Copy link
Owner

Hi Lucas, sorry for the delay in getting to these, I've been super busy the past couple of months I'm afraid. Thanks for sticking with this, I'll get to reviewing this once life is slightly less crazy.

@LucasBorboleta
Copy link
Author

LucasBorboleta commented Mar 17, 2021 via email

@kstruempf
Copy link

kstruempf commented May 4, 2022

Hey :) Just wanted to check in and see if you have plans to merge these changes @pbsinclair42? Briefly looking them over they seem very reasonable 👍

@LucasBorboleta
Copy link
Author

Konstantin,
I am happy that you appreciate my contribution. The intent was to provide a simple, but complete, example of a usage of Paul's MCTS library, which sounds good for discovering the Monte Carlo Tree Search approach.
Unfortunaltey, Paul seems to be busy with other stuff in his life.
Cheers, Lucas

@kstruempf
Copy link

@LucasBorboleta since this repo seems to be inactive I decided to fork it and keep working there. I did add this PR as a patch to my code base. I am using this package in another project so it will be nice if it follows conventions...
I plan on making a couple of changes like renaming the function / classes so that they follow the Python Naming Convention, structuring the codebase to multiple packages and add abstract classes for State and Action so that they can be extended more easily by users of the package and also ad a CI/CD pipeline (GitHub Actions).

@kstruempf
Copy link

I did get started on my endeavour in this repo and published v2.0.0 pypi package in case anyone is interested :)

@LucasBorboleta
Copy link
Author

Konstantin,
Good to know that you are making this MCTS projet alive. Applying common Python naming convention might also help.
In a way of you choice, could you mention, my name "Lucas Borboleta" as associated to the example "Connect(m,n,k)" ? Well, unless it appears automatically from Git historical mechanims. Thanks.

@kstruempf
Copy link

kstruempf commented May 14, 2022

Sure :) I added a patch of this PR to the repo so your account is linked with the corresponding commit, but I will mention you in the readme as well as the author of the example :)

@LucasBorboleta
Copy link
Author

All right !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants