Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: db.json can be relative since happi v1.14.0 (Jul 2022) #38

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Dec 6, 2022

db.json can be relative to happi.cfg since happi v1.14.0 (Jul 2022)

  • This PR makes it relative
  • This PR makes it easier for non-PCDS machines to use the happi database

tangkong
tangkong previously approved these changes Dec 6, 2022
Copy link

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I sometimes used the happi cfg to remember what the /reg/g/pcds... path is, that's a me problem. I like this 👍

ZLLentz
ZLLentz previously approved these changes Dec 6, 2022
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deployed in pcds-5.4.2
Here are the currently deployed hutch python versions (* = too old for this to work)

cxi/cxienv:export CONDA_ENVNAME="pcds-5.2.1" (*)
det/detenv:export CONDA_ENVNAME="pcds-3.3.0" (*)
icl/iclenv:export CONDA_ENVNAME="pcds-4.2.0" (*)
las/lasenv:export CONDA_ENVNAME="pcds-5.3.1" (*)
mec/mecenv:export CONDA_ENVNAME="pcds-5.2.0" (*)
mfx/mfxenv:export CONDA_ENVNAME="pcds-5.5.1"
rix/rixenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
tmo/tmoenv:export CONDA_ENVNAME="pcds-5.5.1"
tst/tstenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
ued/uedenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
xcs/xcsenv:export CONDA_ENVNAME="pcds-5.4.1" (*)
xpp/xppenv:export CONDA_ENVNAME="pcds-5.5.0"

I think this is good to go for master branch but we need to wait to drop it into the deploy branch

@klauer
Copy link
Contributor Author

klauer commented Dec 6, 2022

I didn't realize those were so far behind. Back to draft this goes.

@klauer klauer marked this pull request as draft December 6, 2022 19:00
@ZLLentz
Copy link
Member

ZLLentz commented Dec 6, 2022

It should be fine as long as we wait on merging it into the deploy branch

@klauer
Copy link
Contributor Author

klauer commented Dec 6, 2022

I'd rather not have something in master that we have to be super careful about merging back in. It's better to leave it here as a visible indicator of "we want to do this but we're waiting for this reason..." in my opinion

@klauer
Copy link
Contributor Author

klauer commented Sep 7, 2023

As of today, who is still below pcds-5.4.2?

cxi/cxienv:export CONDA_ENVNAME="pcds-5.7.2"
det/detenv:export CONDA_ENVNAME="pcds-3.3.0" (*)
icl/iclenv:export CONDA_ENVNAME="pcds-4.2.0" (*)
las/lasenv:export CONDA_ENVNAME="pcds-5.3.1" (*)
mec/mecenv:export CONDA_ENVNAME="pcds-5.2.0" (*)
mfx/mfxenv:export CONDA_ENVNAME="pcds-5.7.2"
rix/rixenv:export CONDA_ENVNAME="pcds-5.7.2"
tmo/tmoenv:export CONDA_ENVNAME="pcds-5.7.1"
tst/tstenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
ued/uedenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
xcs/xcsenv:export CONDA_ENVNAME="pcds-5.7.3"
xpp/xppenv:export CONDA_ENVNAME="pcds-5.7.2"

That is: det, icl, las, mec, tst, ued
We're better off than we were!
We should:

  • Ping the laser controls team about upgrading
  • Ping MEC about upgrading
  • UED has no happi devices that I can see - I have a feeling it can be ignored
  • TST, ICL, DET - can we just upgrade these to latest?

@klauer klauer dismissed stale reviews from ZLLentz and tangkong September 7, 2023 14:40

stale

@klauer
Copy link
Contributor Author

klauer commented Nov 15, 2023

$ /cds/group/pcds/pyps/apps/hutch-python
$ grep '^export CONDA_ENVNAME' */*env |sort
cxi/cxienv:export CONDA_ENVNAME="pcds-5.8.0"
det/detenv:export CONDA_ENVNAME="pcds-3.3.0" (*)
icl/iclenv:export CONDA_ENVNAME="pcds-4.2.0" (*)
las/lasenv:export CONDA_ENVNAME="pcds-5.3.1" (*)
mec/mecenv:export CONDA_ENVNAME="pcds-5.2.0" (*)
mfx/mfxenv:export CONDA_ENVNAME="pcds-5.7.2"
rix/rixenv:export CONDA_ENVNAME="pcds-5.7.2"
tmo/tmoenv:export CONDA_ENVNAME="pcds-5.7.1"
tst/tstenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
ued/uedenv:export CONDA_ENVNAME="pcds-5.3.0" (*)
xcs/xcsenv:export CONDA_ENVNAME="pcds-5.7.3"
xpp/xppenv:export CONDA_ENVNAME="pcds-5.7.2"

As of today, the story has not changed. We should follow up with the actions from my last comment, I think.

@tangkong
Copy link

This entirely slipped my mind. I'll shoot out some slack messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants