Instead of creating a new tab, use current connection to do reconnection #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| _this->NewCon( con->m_Site.m_Name, con->m_Site.m_URL, &con->m_Site); | ||
| con->Reconnect(); |
There was a problem hiding this comment.
You have to follow the consistent coding style.
NCTULouis
changed the title
NCTULouis
changed the title
| @@ -1759,12 +1759,11 @@ void CMainFrame::OnEmoticons(GtkMenuItem* mitem UNUSED, CMainFrame* _this) | |||
| void CMainFrame::OnReconnect(GtkMenuItem* mitem UNUSED, CMainFrame* _this) | |||
| { | |||
| CTelnetCon* con = _this->GetCurCon(); | |||
|
|
|||
There was a problem hiding this comment.
Don't change the coding style.
When click the reconnect button, the previous version will create a new tab(a new connection) to do reconnection. Instead of doing this, we use the current connection(current tab) to do reconnection. Fix issue pcman-bbs#33
holishing
requested changes
Jun 7, 2020
|
another problem of this PR is that when we "click reconnect button"(or Ctrl+R/Ctrl+Insert), the old active telnet/ssh connection is "active but hidden". This behavior will cause lots of problem, for e.g., fork too much telnet/ssh process in background. So it's not proper to accept this changes. Closed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
When click the reconnection button, the previous version will create a new tab(a new connection) to do reconnection.
Instead of doing this, we use the current connection(current tab) to do reconnection.
Fix issue #33
Thank you!