Fix collections filtering not working when custom properties set #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pdevito3,
First of all I would like to thank you for the great effort maintaining the library.
There is a bug when setting custom or derived properties, collection filtering stops working because the
ParameterReplacerreplaces the nested parameter types. This PR addresses this issue and adds some unit tests to prevent breaking in the future.If you comment out the additions on
ParameterReplaceryou will get the error sayingProperty 'System.String Name' is not defined for type 'QueryKit.WebApiTestProject.Entities.Recipes.Recipe'because it tries to look up the Ingredient's Name on theRecipetype and not theIngredient.Any comments are welcomed!