update ex1 and ex2, fix #12 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorice91
requested review from
jbigot,
benoitmartin88,
JAuriac and
Yushan-Wang
Yushan-Wang
reviewed
Nov 28, 2024
Yushan-Wang
reviewed
Nov 28, 2024
Yushan-Wang
reviewed
Nov 28, 2024
JAuriac
reviewed
Dec 12, 2024
| @@ -138,6 +151,8 @@ interlaced. | |||
| Is one better than the other? | |||
| If you do not know the answer to this question, just wait until Ex5. :) | |||
There was a problem hiding this comment.
Unifies.
Suggested change
| If you do not know the answer to this question, just wait until Ex5. :) | |
| If you do not know the answer to this question, just wait until ex5. :) |
solutions/ex2.c
Outdated
| PDI_share("ii", &ii, PDI_OUT); | ||
| // as well as the main field | ||
| PDI_reclaim("ii"); |
There was a problem hiding this comment.
Share and reclaim with different shapes : ABAB or ABBA.
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change the exercise 1 and exercise 2 only.