tutorial update: hdf5_parallel, fix #16 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorice91
requested review from
jbigot,
benoitmartin88,
JAuriac and
Yushan-Wang
Yushan-Wang
reviewed
Dec 6, 2024
| To see your `h5` file in readable file format, you can check the section [Comparison with the `h5dump` command](#h5comparison). | ||
|
|
||
| \warning | ||
| If you relaunch the executable, remember to delete your old `ex9.h5` file before, otherwise the data will not be changed correctly. | ||
|
|
||
|  |
There was a problem hiding this comment.
The images of the tutorial are in pdi/doc/images.
For solving this issue, we need to change the generation of website to avoid duplicate images.
I propose to add a new issue to solve this aftre the validation of all the tutorials.
Yushan-Wang
approved these changes
Dec 6, 2024
JAuriac
reviewed
Dec 20, 2024
Comment on lines
+347
to
348
| In this exercise you will write one single file `ex9.h5`(see `ex9.yml`) with parallel HDF5 whose content | ||
| should be independent from the number of processes used. |
There was a problem hiding this comment.
Keep maximum code line length to 80.
Suggested change
| In this exercise you will write one single file `ex9.h5`(see `ex9.yml`) with parallel HDF5 whose content | |
| should be independent from the number of processes used. | |
| In this exercise you will write one single file `ex9.h5`(see `ex9.yml`) with | |
| parallel HDF5 whose content should be independent from the number of | |
| processes used. |
| Once again, you only need to modify the YAML file in this exercise, no need to | ||
| touch the C file. | ||
|
|
||
| \attention You need to do this exercise with a parallel version of HDF5 and the \ref Decl_HDF5_plugin "Decl'HDF5 plugin" compiled in parallel. |
There was a problem hiding this comment.
Suggested change
| \attention You need to do this exercise with a parallel version of HDF5 and the \ref Decl_HDF5_plugin "Decl'HDF5 plugin" compiled in parallel. | |
| \attention You need to do this exercise with a parallel version of HDF5 and the | |
| \ref Decl_HDF5_plugin "Decl'HDF5 plugin" compiled in parallel. |
|
|
||
| * Set the size of the dataset to take the global (parallel) array size into | ||
| account. | ||
| \note we have added the directive `collision_policy: write_into` of the \ref Decl_HDF5_plugin "Decl'HDF5 plugin" (see section COLLISION_POLICY). This parameter is used to define what to do when writing to a file or dataset that already exists. |
There was a problem hiding this comment.
Suggested change
| \note we have added the directive `collision_policy: write_into` of the \ref Decl_HDF5_plugin "Decl'HDF5 plugin" (see section COLLISION_POLICY). This parameter is used to define what to do when writing to a file or dataset that already exists. | |
| \note We have added the directive `collision_policy: write_into` of the | |
| \ref Decl_HDF5_plugin "Decl'HDF5 plugin" (see section COLLISION_POLICY). | |
| This parameter is used to define what to do when writing to a file or dataset | |
| that already exists. |
| You will need to multiply the local size by the number of processes in each | ||
| dimension (use `psize`). | ||
|
|
||
| * Ensure the dataset selection of each process does not overlap with the others. | ||
| You will need to make a selection in the dataset that depends on the global | ||
| coordinate of the local data block (use `pcoord`). | ||
|
|
||
| Match the output from `ex9.h5dump`, that should be independent from the number | ||
| of processes used. You can easily check if the files are the same by running: | ||
| You should be able to match the expected output described in `ex9.h5dump`. You can easily check if the files are the same by running: |
There was a problem hiding this comment.
Suggested change
| You should be able to match the expected output described in `ex9.h5dump`. You can easily check if the files are the same by running: | |
| You should be able to match the expected output described in `ex9.h5dump`. | |
| You can easily check if the files are the same by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.