fix #24, update ex3 to ex5 (hdf5) #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorice91
requested review from
jbigot,
benoitmartin88,
JAuriac and
Yushan-Wang
Yushan-Wang
reviewed
Nov 28, 2024
ex5.yml
Outdated
| when: '$ii>0 & ' # `&' is a local `and' operation | ||
| #*** enable the output upon the event | ||
| #... | ||
| #*** enable the output when ii>0 and ii<3 (`&` is a local `and` operation ) |
There was a problem hiding this comment.
I don't remember why we put "local" here. Now it seems confusing...
There was a problem hiding this comment.
The solution of ex5.yml instead mentions a "logical" operation, it must be a typographical error.
Yushan-Wang
reviewed
Nov 28, 2024
Co-authored-by: yushan wang <[email protected]>
Yushan-Wang
approved these changes
Dec 6, 2024
JAuriac
reviewed
Dec 12, 2024
ex5.yml
Outdated
| when: '$ii>0 & ' # `&' is a local `and' operation | ||
| #*** enable the output upon the event | ||
| #... | ||
| #*** enable the output when ii>0 and ii<3 (`&` is a local `and` operation ) |
There was a problem hiding this comment.
The solution of ex5.yml instead mentions a "logical" operation, it must be a typographical error.
| PDI_share("pcoord", pcoord, PDI_OUT); | ||
| PDI_reclaim("pcoord"); | ||
| PDI_share("dsize", dsize, PDI_OUT); | ||
| PDI_reclaim("dsize"); | ||
| PDI_share("psize", psize, PDI_OUT); | ||
| PDI_reclaim("psize"); | ||
| PDI_share("main_field", cur, PDI_OUT); | ||
| PDI_reclaim("main_field"); | ||
|
|
||
|
|
||
| // the main loop | ||
| for (; ii<10; ++ii) { |
There was a problem hiding this comment.
May prefer less iterations to help with log readability.
Co-authored-by: JAuriac <[email protected]>
Co-authored-by: JAuriac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.