Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch boost::hash2::endian to std::endian when available #26

Closed
wants to merge 1 commit into from
Closed

Switch boost::hash2::endian to std::endian when available #26

wants to merge 1 commit into from

Conversation

HowardHinnant
Copy link

Only very lightly tested. But what if boost::hash2::endian becomes an alias for std::endian when std::endian is available?

@pdimov
Copy link
Owner

pdimov commented Dec 3, 2024

I'm not a fan of things conditionally becoming std::things (except when implementation details) because this creates more (ODR) problems than it solves.

@HowardHinnant
Copy link
Author

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HowardHinnant @pdimov