-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Sorting 'get active users' issue #14
base: develop
Are you sure you want to change the base?
Conversation
@johnsBeharry @micey969 I added a new function Ideally, there should be a way to filter this list down to just the users within the chat the bot command is called, but as of right now I haven't found any easy ways to get a list of those users using the Telegram API. The closest thing I've found is to manually document the current users in particular chats and then to keep track of added/removed users using this method. |
@vindard what's the expected behavior when using Could you help fill these gaps? Scenario: Get list of active users
Given there are 10 users in a telegram group
When a user types `/active` command in the group
Then ___
Scenario: Send dogecoin to all active users
Given there are 10 users in a telegram group
When a user uses `/rain` command in the group
Then ___ |
@johnsBeharry sure man Scenario: Get list of active users
Given there are 10 users in a telegram group
When a user types `/active` command in the group
Then the number of active users is returned, with active defined as users who have shown activity within the last 600 seconds Note: it's unclear from the code where this user list is meant to be drawn from and how the 'time since last active' data point would be obtained to determine who is active. Telegram's API doesn't support either of these features directly. Scenario: Send dogecoin to all active users
Given there are 10 users in a telegram group
When a user uses `/rain` command in the group
Then 10 doge is sent to all active users from the user calling the command Note: This command only sends doge to "active persons" as defined in the |
2bf280f
to
fe833c8
Compare
@vindard the stalest branch ever? sorry I never got to merging this. ill have a look at it over the weekend. |
@johnsBeharry we might need to revisit that |
Issue #13
There's currently a
getActive()
function and a few bot commands (/active
,/rain
) that make use of it. This function doesn't work as the code is right now though, so this PR is to explore whether this can be fixed or whether any decent alternatives can be added.