feat: add required applications check to start command flow #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Added a check for required applications (jq, curl) to the start command flow.
Details: I encountered an issue where running the start command without having jq installed caused all containers to appear as if they were running correctly. However, when using Fleet, the agent was unable to receive messages.
To prevent similar issues for other users, this PR introduces a validation step within the start command. The script now checks for the presence of all necessary applications before proceeding to start the containers. If any required application is missing, the script will notify the user with a clear message and exit, ensuring that all dependencies are met before execution continues.