fix tests

pebble-dev · Jun 10, 2024 · fc97c07 · fc97c07
1 parent 9ab3501
commit fc97c07
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/domain/connection/connection_state_provider.dart b/lib/domain/connection/connection_state_provider.dart
@@ -35,14 +35,21 @@ class ConnectionCallbacksStateNotifier
   void dispose() {
     ConnectionCallbacks.setup(null);
     _connectionControl.cancelObservingConnectionChanges();
-    super.dispose();
+    //XXX: Potentially a bug in riverpod
+    if (mounted) {
+      super.dispose();
+    }
   }
 }
 
 final AutoDisposeStateNotifierProvider<ConnectionCallbacksStateNotifier, WatchConnectionState>
     connectionStateProvider =
     StateNotifierProvider.autoDispose<ConnectionCallbacksStateNotifier, WatchConnectionState>((ref) {
   final notifier = ConnectionCallbacksStateNotifier();
-  ref.onDispose(notifier.dispose);
+  ref.onDispose(() {
+    if (notifier.mounted) {
+      notifier.dispose();
+    }
+  });
   return notifier;
 });
diff --git a/test/fakes/fake_permissions_check.dart b/test/fakes/fake_permissions_check.dart
@@ -5,6 +5,7 @@ class FakePermissionCheck implements PermissionCheck {
   bool reportedCalendarPermission = true;
   bool reportedLocationPermission = true;
   bool reportedNotificationAccess = true;
+  bool reportedCallsAccess = true;
 
   @override
   Future<BooleanWrapper> hasBatteryExclusionEnabled() {
@@ -33,4 +34,11 @@ class FakePermissionCheck implements PermissionCheck {
     wrapper.value = reportedNotificationAccess;
     return Future.value(wrapper);
   }
+
+  @override
+  Future<BooleanWrapper> hasCallsPermissions() {
+    final wrapper = BooleanWrapper();
+    wrapper.value = reportedCallsAccess;
+    return Future.value(wrapper);
+  }
 }