refactor: change Paper, ContentArea chileren type to ReactElementChildren #914
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YimJiYoung is attempting to deploy a commit to the Class101 Team on Vercel. To accomplish this, @YimJiYoung needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
kang-heewon
reviewed
Dec 22, 2023
| import { withVariation } from '@vibrant-ui/core'; | ||
|
|
||
| export type ContentAreaProps = { | ||
| padding?: ResponsiveValue<boolean>; | ||
| children: ReactElementChild; | ||
| children: ReactElementChildren; |
There was a problem hiding this comment.
근데 여러 요소면 Stack으로 명시적으로 감싸자고 해서 의도된거 아니였나용?
There was a problem hiding this comment.
그렇긴한데 뷰가 중첩되는게 조금 걸려서 .. 기본으로 수직으로 쌓이니 VStack의 경우는 생략해서 쓰고 싶은 마음이 ..
에러가 나는 경우가 아니라면 타입은 좀 더 열려있어도 되지 않을까 하는 생각을 해보았어요
There was a problem hiding this comment.
근데 Paper나 ContentArea를 너무 VStack처럼 쓰게 되지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paper나 ContentArea 내에 여러 요소를 렌더링하려면 VStack이나 Fragment로 감싸줘야하는 번거로움이 있어서 children 타입을 허용해줍니다