Fix Angular errors #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vishalshrm539
commented
Sep 27, 2023
vishalshrm539
commented
- Fixed the angular errors seen as mentioned in BUG-827920.
- Did some cleanup.
vishalshrm539
requested review from
JEAxero,
tumms2021389,
4manasa and
samhere06
tumms2021389
requested changes
Sep 27, 2023
| @@ -17,6 +17,15 @@ export class ComponentMapperComponent implements OnInit, OnChanges { | |||
| public componentRef: ComponentRef<any> | undefined; | |||
| public isInitialized: boolean = false; | |||
|
|
|||
| private componentsRequireDisplayOnlyFAProp: Array<string> = [ | |||
There was a problem hiding this comment.
Have this array as a constant value outside component, not as a component property
There was a problem hiding this comment.
Yeah, that can be done.
| // Eventual plan is to get rid of this particular prop | ||
| if(propName !== "displayOnlyFA$" || (propName === "displayOnlyFA$" && this.componentsRequireDisplayOnlyFAProp.includes(this.name))){ | ||
| this.componentRef.setInput(propName, this.props[propName]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| if (this.props[propName] !== undefined) { | |
| // We'll set 'displayOnlyFA$' prop only to the components which really need it | |
| // Eventual plan is to get rid of this particular prop | |
| if(propName === "displayOnlyFA$" && this.componentsRequireDisplayOnlyFAProp.includes(this.name)){ | |
| continue; | |
| } | |
| this.componentRef.setInput(propName, this.props[propName]); | |
| } |
There was a problem hiding this comment.
This won't work , I think you forgot to add "!" in the if check. Anyways, the existing condition looks ok and more readable, no?
There was a problem hiding this comment.
yes, I forgot to add ! before includes condition
if(propName === "displayOnlyFA$" && !this.componentsRequireDisplayOnlyFAProp.includes(this.name))
This way you will have separate logic for skipping property binding
tumms2021389
approved these changes
Sep 28, 2023
vishalshrm539
force-pushed
the
bug/tor/BUG-827920
branch
from
395a106 to
9822996
Compare
tumms2021389
added a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.