Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style issues and improve test files #76

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Fix style issues and improve test files #76

merged 2 commits into from
Oct 31, 2023

Conversation

vishalshrm539
Copy link
Contributor

@vishalshrm539 vishalshrm539 commented Oct 31, 2023 •
edited
Loading

  • Fixed few style issues in NavBar, WSS portal, etc.
  • Removed hard-coded app URL in the tests.
  • Removed unnecessay props being passed within ApppShell component(Angular was throwing a warning/error).

JEAxero
JEAxero approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@JEAxero JEAxero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Tested. Approved.

@vishalshrm539 vishalshrm539 merged commit 7bd23f1 into master Oct 31, 2023
2 checks passed
@tumms2021389 tumms2021389 deleted the mod/tor/TASK-1524186 branch March 20, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEAxero JEAxero JEAxero approved these changes

@tumms2021389 tumms2021389 Awaiting requested review from tumms2021389

@4manasa 4manasa Awaiting requested review from 4manasa

@paulgagnon-pega paulgagnon-pega Awaiting requested review from paulgagnon-pega

@samhere06 samhere06 Awaiting requested review from samhere06

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalshrm539 @JEAxero