Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SRS network policies optionals and enabled by default #735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eralumin
Copy link

Hi, I just create this PR to make SRS Network Policies optionals but enabled by default.

This cause somes issues on my company context.

@eralumin eralumin requested review from a team as code owners April 17, 2024 16:05
@kishorv10
Copy link
Contributor

@eralumin Can you create/link the github issue for the PR? You can provide more details about the requirement in the issue.

@kishorv10
Copy link
Contributor

@reddy-srinivas @bhowd1 @ravitejamekapega @pegasystems/searchservice Can you review the PR? You can have a look at (FDBK-111254) for more details of the ask.

Copy link
Contributor

@bhowd1 bhowd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test the changes locally? Also, can you please fix the lint issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants