Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Embedded sample code #211

Merged
merged 1 commit into from
Oct 21, 2024
Merged

refactor: Embedded sample code #211

merged 1 commit into from
Oct 21, 2024

Conversation

tumms2021389
Copy link
Collaborator

No description provided.

@tumms2021389 tumms2021389 self-assigned this Oct 21, 2024
@tumms2021389 tumms2021389 changed the title refactor: Mashup sample code refactor: Embedded sample code Oct 21, 2024
Copy link
Collaborator

@niallriddell niallriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tumms2021389 have you updated the tests?

@tumms2021389
Copy link
Collaborator Author

tumms2021389 commented Oct 21, 2024

@tumms2021389 have you updated the tests?

No @niallriddell

Copy link
Collaborator

@niallriddell niallriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tumms2021389 tumms2021389 merged commit 603d95b into main Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants