Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: changing displayMode value to DISPLAY_ONLY #222

Merged
merged 1 commit into from
Nov 1, 2024
Merged

refactor: changing displayMode value to DISPLAY_ONLY #222

merged 1 commit into from
Nov 1, 2024

Conversation

tumms2021389
Copy link
Collaborator

@tumms2021389 tumms2021389 commented Nov 1, 2024 •
edited
Loading

changes include,

  • changing displayMode value to DISPLAY_ONLY
  • @pega/auth library version upgrade to 0.2.15
  • removed fast-deep-equal package and make use of PCore.isDeepEqual api

@tumms2021389 tumms2021389 self-assigned this Nov 1, 2024
niallriddell
niallriddell approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@niallriddell niallriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tumms2021389 tumms2021389 merged commit 6158d68 into main Nov 1, 2024
4 checks passed
@tumms2021389 tumms2021389 deleted the fix/display_mode branch November 1, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niallriddell niallriddell niallriddell approved these changes

@vishalshrm539 vishalshrm539 Awaiting requested review from vishalshrm539

@4manasa 4manasa Awaiting requested review from 4manasa

@samhere06 samhere06 Awaiting requested review from samhere06

Assignees

@tumms2021389 tumms2021389

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tumms2021389 @niallriddell