Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error details two column #223

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

samhere06
Copy link
Contributor

In case of details 2 column. when supposed to render view ,app is erroring out as pconn object is not supplied to details field, In same use case getting error in table so made change for it as well.

niallriddell
niallriddell previously approved these changes Nov 4, 2024
Copy link
Collaborator

@niallriddell niallriddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error to the console log is OK in this case. In the future, if required, we should consider adding error handling into the update lifecycle in bridgebase.

Copy link
Collaborator

@tumms2021389 tumms2021389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tumms2021389 tumms2021389 merged commit bf8e432 into main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants