Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grep pattern fixed to remove line comments #311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: grep pattern fixed to remove line comments #311

wants to merge 3 commits into from

Commits on Feb 24, 2023

  1. fix: Don't escape # in grep pattern 

    Running `pelias` yields the error `grep: warning: stray \ before #`. This can be fixed by not escaping `#` in the grep pattern.
    @langfingaz
    langfingaz committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    e1d6fb6 View commit details
    Browse the repository at this point in the history

  2. fix: Remove line comments 

    The second part of the grep pattern does now remove lines starting with 0 or more whitespace characters followed by #.
    @langfingaz
    langfingaz committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    58fc649 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. refactor: Add quotes; remove subshell; add comments 

    One subshell `(...) &&` was replaced with `if [...]; then`.
    @langfingaz
    langfingaz committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    709579b View commit details
    Browse the repository at this point in the history