Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite downloader #154

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Rewrite downloader #154

merged 2 commits into from
Dec 13, 2016

Conversation

orangejulius
Copy link
Member

The downloader is now similar to the WOF downloader in that it uses
child_process.exec and curl to download data. This seems to be more
reliable than using request and piping to a file.

There were also issues with the progress bar package not showing progress properly, so rather than
sort them out, this allows us to simply remove that package

This change probably will help fix #26, but it's not 100% certain.

The downloader is now similar to the WOF downloader in that it uses
child_process.exec and curl to download data. This seems to be more
reliable than using request and piping to a file.

There were also issues with the progress bar package, so rather than
sort them out, this allows us to simply remove them.

This change probably will help fix #26,
but it's not 100% certain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: invalid signature when unzipping Geonames data file
2 participants