improved matching of street directional prefixes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, it seems as though Removing that blocks only makes one test fail: |
|
Worth noting this regression I spotted which wasn't covered by tests: node bin/cli.js 10 A Main Street
(0.98) ➜ [ { housenumber: '10' }, { street: 'A Main Street' } ]After this PR there are no results returned. The previous parse wasn't correct anyway, so I'm not sure where I stand on it 🤔 The derived PR #180 seems to fix it (the reason is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking over the code today I noticed that the query 'Am Falkplatz' (and friends) are relying on a
StopWordClassificationfor matching.This seems brittle, this PR replaces it with the more robust
DirectionalClassification.I've also removed
amfrom the/de/stopwords.txtfile asAm Falkplatzis a valid streetname in Germany, the preposition shouldn't be ignored.