Merge pull request #365 from pelias/okina

remove okina
pelias · May 28, 2019 · 908e4bd · 908e4bd
2 parents cc3b14e + 0154052
commit 908e4bd
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 2 deletions.
diff --git a/integration/analyzer_peliasIndexOneEdgeGram.js b/integration/analyzer_peliasIndexOneEdgeGram.js
@@ -42,6 +42,7 @@ module.exports.tests.analyze = function(test, common){
 
     // remove punctuation (handled by the char_filter)
     assertAnalysis( 'punctuation', punctuation.all.join(''), ['-','-&'] );
+    assertAnalysis( 'punctuation', 'Hawai‘i', ['h', 'ha', 'haw', 'hawa', 'hawai', 'hawaii'] );
 
     // ensure that very large grams are created
     assertAnalysis( 'largeGrams', 'grolmanstrasse', [

diff --git a/integration/analyzer_peliasPhrase.js b/integration/analyzer_peliasPhrase.js
@@ -46,6 +46,7 @@ module.exports.tests.analyze = function(test, common){
 
     // remove punctuation (handled by the char_filter)
     assertAnalysis( 'punctuation', punctuation.all.join(''), [ '-&' ] );
+    assertAnalysis( 'punctuation', 'Hawai‘i', ['hawaii'] );
 
     suite.run( t.end );
   });

diff --git a/punctuation.js b/punctuation.js
@@ -2,7 +2,7 @@
 // @see: org/apache/lucene/analysis/cn/smart/stopwords.txt
 
 module.exports.all = [
-  ".","`","-","_","=","?","'","|","\"","(",")","{","}","[","]","<",">","*",
+  ".","`","‘","-","_","=","?","'","|","\"","(",")","{","}","[","]","<",">","*",
   "#","&","^","$","@","!","~",":",";","+","《","》","—","－","，","。",
   "、", "：","；","！","·","？","“","”","）","（","【","】","［","］","●"
 ];

diff --git a/test/fixtures/expected.json b/test/fixtures/expected.json
@@ -752,6 +752,7 @@
           "mappings": [
             ".=>",
             "`=>",
+            "‘=>",
             "_=>",
             "==>",
             "?=>",

diff --git a/test/settings.js b/test/settings.js
@@ -364,7 +364,7 @@ module.exports.tests.punctuationCharFilter = function(test, common) {
     var char_filter = s.analysis.char_filter.punctuation;
     t.equal(char_filter.type, 'mapping');
     t.true(Array.isArray(char_filter.mappings));
-    t.equal(char_filter.mappings.length, 47);
+    t.equal(char_filter.mappings.length, 48);
     t.end();
   });
 };