Auto pint #178
Closed
Auto pint #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Crowdin updates
Translation file for commands & tiny cleanup
And also named the job pint and i also named the commit pint. I also changed a bit of code in a lang file to show that it works
The error is caused by the job not finding the branch because the branch exists in a fork and not in the main repo
This now should fix pint
|
My changes do work, only there is one little thing wrong. The job fails because he can't find the branch in this repository and I can't manage to get him to search for the fork repository, but that does not affect the job. As you can see from my tests, he does run pint and then makes a commit. With my last commit I adjusted it so that it is no longer executed when a Pull Request is made, but only when a commit is made, because as I explained at Pull Requests it fails because it can't find the branch. I think with these last changes and tests it is now ready to be merged |
|
You can use a pre commit git hook to run vendor/bin/pint |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes to lint.yml so on each commit it now automatically runs pint and makes a commit named Pint Fixes if needed