Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Roles #502

Merged
merged 54 commits into from
Sep 21, 2024
Merged

Admin Roles #502

merged 54 commits into from
Sep 21, 2024

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jul 22, 2024

Uses spatie/laravel-permission to add roles and permissions (for admins). This does not change subuser permissions! (#193)

A role named "Root Admin" is created during seeding. This role has all permissions and will replace the old root_admin bool.

Example:
grafik
grafik

@Boy132 Boy132 requested a review from lancepioch July 22, 2024 13:30
@dbcaa

This comment was marked as off-topic.

@notAreYouScared
Copy link
Member

Looks good, Seems like we will have a lot of updating to do when we add this.

Things like "restore" & "force delete" aren't useful for us.

@Boy132
Copy link
Member Author

Boy132 commented Aug 1, 2024

Looks good, Seems like we will have a lot of updating to do when we add this.

Yeah, we don't have any view pages for our resources. And we need to check all actions. (plus add any "special" permissions if needed)

Things like "restore" & "force delete" aren't useful for us.

True, I removed them.

Copy link
Member

@notAreYouScared notAreYouScared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what i've tested, all seems well.

Copy link
Contributor

@alexevladgabriel alexevladgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexevladgabriel alexevladgabriel linked an issue Sep 18, 2024 that may be closed by this pull request
database/Seeders/DatabaseSeeder.php Show resolved Hide resolved
config/permission.php Show resolved Hide resolved
app/Filament/Resources/RoleResource.php Outdated Show resolved Hide resolved
app/Filament/Resources/RoleResource.php Outdated Show resolved Hide resolved
tests/Traits/Http/RequestMockHelpers.php Show resolved Hide resolved
@Boy132 Boy132 merged commit fc643f5 into pelican-dev:main Sep 21, 2024
15 checks passed
@Boy132 Boy132 deleted the feature/admin-roles branch September 21, 2024 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Roles and Permissions
5 participants