Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Startup parsing #18

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

QuintenQVD0
Copy link
Contributor

@QuintenQVD0 QuintenQVD0 commented May 22, 2024

Description

Fix the variables in bash compare function been replaced and if their empty then the syntax is invalid.

Changes

This change is desinged by parker.

  • with regex it check if a variable if is in between [[ ]] and if it is replace it with a placeholder. This is needed as Sometimes a variable is used in a compare function and outside of it.
  • then it does a find and replace off all variables what now the placeholder ofc does not match anymore
  • then replace the placeholders back with their original ${} form

Go told me to run some command about a specifc package as it is directly used in a wings file.

Testing

This was tested on the generic nodejs egg what was known for having issues.

@QuintenQVD0
Copy link
Contributor Author

Example
image-4

Copy link
Contributor

@parkervcp parkervcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolve the issues with the empty values.

I may take a crack at updating it again later.

@parkervcp parkervcp merged commit 0ccb1c3 into pelican-dev:main May 24, 2024
6 checks passed
@QuintenQVD0 QuintenQVD0 deleted the startup_parsing_v2 branch May 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants