Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes S3 backup error #26 #32

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fixes S3 backup error #26 #32

merged 1 commit into from
Jul 17, 2024

Conversation

RMartinOscar
Copy link
Contributor

@RMartinOscar RMartinOscar commented Jul 12, 2024 •
edited
Loading

Fixes #26 by adding back mkdir for the temporary archive that gets stored locally before upload to S3

Tested locally with Minio should work with S3/R2 as the issue is with the temp dir not being made and not the API itself

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2024
View reviewed changes
server/backup/backup_s3.go Dismissed Show dismissed Hide dismissed
server/backup/backup_s3.go Dismissed Show dismissed Hide dismissed
@RMartinOscar
Copy link
Contributor Author

An other way of doing this would be to use TmpDirectory instead like we do during the server install process or have the user set tmp_backup_dir: /tmp (or whatever dir they want) in config.yml

@QuintenQVD0
Copy link
Contributor

https://github.com/pelican-dev/wings/pull/30/files

Do it like this, call clean on the path and then use os.stat

@iamkubi iamkubi merged commit db2d1c3 into pelican-dev:main Jul 17, 2024
6 checks passed
@RMartinOscar RMartinOscar deleted the patch-1 branch July 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 backup error
3 participants
@RMartinOscar @QuintenQVD0 @iamkubi