Keep alignment with plugin template via Cruft #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Justin, I apologize for the big delay to get to this. Summer vacations got in the way… I am going to merge the cruft branch and make a new release of avatar, just to be sure everything goes fine with the pipeline. |
|
Should I migrate the other plugins that I maintain (graphviz, linkclass, and inclue-markdwon) along the same lines of the PR, as well? |
|
Yes, I think that would be beneficial. While there's no immediate imperative, bringing plugins into closer alignment with changes to the upstream plugin template will make it easier to keep them in alignment. You can use steps 2–7 of the relevant documentation to assist with this process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to (1) bring this plugin in alignment with the latest changes to the Pelican plugin template, and (2) use Cruft to make it easier to maintain said alignment going forward.