Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barebox: also use image suffix for barebox-flash-image and EFI #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohieb
Copy link
Contributor

@rohieb rohieb commented Nov 10, 2020

This makes it possible to have multiple barebox packages in a BSP without them overwriting each other's image in the deploy stage, even when they're building an EFI image or only a barebox-flash-image.

recipes-bsp/barebox/barebox.inc Outdated Show resolved Hide resolved
This makes it possible to have multiple barebox packages in a BSP
without them overwriting each other's image in the deploy stage, even
when they're building an EFI image or only a barebox-flash-image.

Signed-off-by: Roland Hieber <[email protected]>
@rohieb rohieb force-pushed the topic/barebox-image-suffix branch from eee4c71 to cf06352 Compare July 8, 2021 19:19
@ejoerns
Copy link
Member

ejoerns commented Jul 22, 2021

About this, I am not sure whether a suffix is the right choice here or if we should simply allow setting the resulting artifact name.

Naming the EFI binary barebox.efi.something also sounds inconvenient for me. Something like `barebox-${MACHINE}.efi" would be more appropriate I guess.

It might be also worth looking into u-boot.inc and copy some approaches from there.
This allows setting UBOOT_ELF to the expected u-boot binary name and installs this into ${DEPLOYDIR}/u-boot-${type}-${PV}-${PR}.${UBOOT_ELF_SUFFIX}. We could probably also use a similar approach to bypass the default deploy handling and instead of deploying everything that was built with barebox, deploy only ${BAREBOX_ELF} to a configurable destination. This would be applicable to more than just barebox.efi.

Further suggestions very welcome..

Also, an added variable should have a bit of documentation in the class, at least with a VARNAME[doc] = "description" entry and probably a weak default to an empty string?

@ejoerns
Copy link
Member

ejoerns commented Aug 23, 2021

Any further news/ideas here?

@a3f
Copy link
Member

a3f commented Apr 28, 2022

I have since learnt that barebox for close to 7 years now has been generating a barebox-flash-images file with a list of generated images.

@a3f
Copy link
Member

a3f commented Nov 28, 2022

I have since learnt that barebox for close to 7 years now has been generating a barebox-flash-images file with a list of generated images.

This is now used in PTXdist:

	@$(foreach image, $(shell cat $(BAREBOX_BUILD_DIR)/barebox-flash-images), \
		$(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/$(image))$(ptx/nl) \
		if [ ! -e $(IMAGEDIR)/barebox-image ]; then \
			$(call ptx/image-install-link, BAREBOX, $(notdir $(image)), barebox-image); \
		fi$(ptx/nl))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants