umpf: omit hash/version info on show without --identical #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The topic-range and hashinfo information won't be used later on, unless --identical is given. It thus makes sense to ignore them in umpf show too, unless the user requests them with --identical. Signed-off-by: Ahmad Fatoum <[email protected]>
a3f
force-pushed
the
afa/show-identical
branch
from
14303a1 to
814ca58
Compare
|
So there are basically two use-cases for
You're only thinking about the second one. It would be really confusing to change the default for the first one. I think the second use-case actually deserves a separate command. Maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
topic-rangeandhashinfoinformation won't be used later on, unless--identicalis given. It thus makes sense to ignore them inumpf showtoo, unless the user requests them with--identical.