On http changes for workflow progress #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgx027
reviewed
Oct 14, 2016
| var self = this; | ||
|
|
||
| if (_.has(message, 'nodeId')) { | ||
| return self.postNodeNotification(message); | ||
| } else if (_.has(message, 'taskId') && _.has(message, 'progress')) { | ||
| // This will be progress update notification if taskId is specified | ||
| return self.postProgressEvent(message); |
There was a problem hiding this comment.
I would suggest to refactor this to following so other develops can choose to develop other task notifications other than progress notification.
} else if (_.has(message, 'taskId')) {
if (_.has(message, 'progress'))
{
// This will be progress update notification if taskId is specified
return self.postProgressEvent(message);
}
if (_.has(message, 'SOMETHING_ELSE'))
{
// others can choose to post other kind of task notification without need to modify your code.
}
cgx027
reviewed
Oct 14, 2016
| return eventsProtocol.publishBroadcastNotification(message) | ||
| .then(function () { | ||
| return message; | ||
| }); | ||
| }; | ||
|
|
||
| return new notificationApiService(); | ||
| NotificationApiService.prototype.postProgressEvent = function(data) { |
There was a problem hiding this comment.
I would suggest to change function name to postProgressNotification to be better aligned with previous function. This is not a big deal anyway.
cgx027
reviewed
Oct 14, 2016
| taskName: graphObject[0].tasks[data.taskId].friendlyName, | ||
| progress: data.progress | ||
| } | ||
| }; |
There was a problem hiding this comment.
suggest to return something in this .then block. One option would be combine following then block with this one.
cgx027
reviewed
Oct 14, 2016
| return new notificationApiService(); | ||
| NotificationApiService.prototype.postProgressEvent = function(data) { | ||
| var progressData; | ||
| return waterline.taskdependencies.find({taskId: data.taskId}) |
There was a problem hiding this comment.
Copy @yyscamper 's comments at on-taskgraph:
use 'findOne instead offind, so that you can use graphObject rather
than graphObject[0]` in following code.
cgx027
reviewed
Oct 14, 2016
pengz1
pushed a commit
that referenced
this pull request
Jul 6, 2017
add callback handler for wsman microservices
pengz1
pushed a commit
that referenced
this pull request
Aug 18, 2017
Add SEL/LC logging via inventory microservice. Expose through northb…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for review.