feat: added placeholder for sorting icon, so it does not change width…

… when sorting
pennions · Jul 8, 2024 · c50898f · c50898f
1 parent 1f5091a
commit c50898f
Show file tree

Hide file tree

Showing 15 changed files with 29 additions and 9 deletions.
diff --git a/dist/flightkit-v0.0.8/flightkit.min.js b/dist/flightkit-v0.0.8/flightkit.min.js
diff --git a/dist/flightkit-v0.0.8/flightkit.js → dist/flightkit-v0.0.9/flightkit.js b/dist/flightkit-v0.0.8/flightkit.js → dist/flightkit-v0.0.9/flightkit.js
@@ -954,11 +954,17 @@
                 this.base.addEvent(`#${thId}`, 'click', this.sortData);
 
                 const orderProperties = this.orderBy.find(obp => obp.propertyName === header);
+                const iconElement = document.createElement('span');
                 if (orderProperties) {
-                    const iconElement = document.createElement('span');
                     iconElement.innerHTML = orderProperties.direction === 'asc' ? sortAscendingIcon : sortDescendingIcon;
-                    thCell.append(iconElement);
                 }
+                else {
+                    iconElement.style.display = 'inline-block';
+                    iconElement.style.width = "24px";
+                }
+
+                thCell.append(iconElement);
+
                 headerRow.append(thCell);
             }
             tableHead.append(headerRow);

diff --git a/dist/flightkit-v0.0.9/flightkit.min.js b/dist/flightkit-v0.0.9/flightkit.min.js
diff --git a/docs/cdn/ibiss-v0.0.9/avian.min.css b/docs/cdn/ibiss-v0.0.9/avian.min.css
diff --git a/docs/cdn/ibiss-v0.0.9/flightkit.min.js b/docs/cdn/ibiss-v0.0.9/flightkit.min.js
diff --git a/docs/cdn/ibiss-v0.0.9/htmx-ibiss-ui.min.js b/docs/cdn/ibiss-v0.0.9/htmx-ibiss-ui.min.js
diff --git a/docs/cdn/ibiss-v0.0.9/rocket.min.js b/docs/cdn/ibiss-v0.0.9/rocket.min.js
diff --git a/docs/js/flightkit.min.js b/docs/js/flightkit.min.js
diff --git a/documentation/public/cdn/ibiss-v0.0.9/avian.min.css b/documentation/public/cdn/ibiss-v0.0.9/avian.min.css
diff --git a/documentation/public/cdn/ibiss-v0.0.9/flightkit.min.js b/documentation/public/cdn/ibiss-v0.0.9/flightkit.min.js
diff --git a/documentation/public/cdn/ibiss-v0.0.9/htmx-ibiss-ui.min.js b/documentation/public/cdn/ibiss-v0.0.9/htmx-ibiss-ui.min.js
diff --git a/documentation/public/cdn/ibiss-v0.0.9/rocket.min.js b/documentation/public/cdn/ibiss-v0.0.9/rocket.min.js
diff --git a/documentation/public/js/flightkit.min.js b/documentation/public/js/flightkit.min.js
diff --git a/flightkit/components/table.js b/flightkit/components/table.js
@@ -525,11 +525,17 @@ export class FlightkitTable extends HTMLElement {
             this.base.addEvent(`#${thId}`, 'click', this.sortData);
 
             const orderProperties = this.orderBy.find(obp => obp.propertyName === header);
+            const iconElement = document.createElement('span');
             if (orderProperties) {
-                const iconElement = document.createElement('span');
                 iconElement.innerHTML = orderProperties.direction === 'asc' ? sortAscendingIcon : sortDescendingIcon;
-                thCell.append(iconElement);
             }
+            else {
+                iconElement.style.display = 'inline-block';
+                iconElement.style.width = "24px";
+            }
+
+            thCell.append(iconElement);
+
             headerRow.append(thCell);
         }
         tableHead.append(headerRow);

diff --git a/package.json b/package.json
@@ -1,8 +1,8 @@
 {
   "name": "@pennions/ibiss",
-  "version": "0.0.8",
+  "version": "0.0.9",
   "avian_version": "0.0.2",
-  "flightkit_version": "0.0.8",
+  "flightkit_version": "0.0.9",
   "htmx_plugin_version": "0.0.1",
   "rocketjs_version": "0.0.1",
   "description": "Frontend library of Pennions",