Notifcation Bug Fix + Comments Removed

pennlabs · Oct 27, 2024 · fb1086a · fb1086a
1 parent bf2a426
commit fb1086a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/frontend/components/Course/CourseWrapper.tsx b/frontend/components/Course/CourseWrapper.tsx
@@ -46,8 +46,9 @@ const CourseWrapper = ({ render, ...props }: CourseProps) => {
     useEffect(() => setSupportsNotifs(browserSupportsNotifications()), []);
 
     const toggleNotifs = () => {
-        setNotifs(!notifs);
-        localStorage.setItem("notifs", !notifs ? "true" : "false");
+        const newNotifs = !notifs;
+        setNotifs(newNotifs);
+        localStorage.setItem("notifs", newNotifs ? "true" : "false");
         document.body.focus();
     };
 

diff --git a/frontend/components/Course/InstructorQueuePage/QueueFormFields.tsx b/frontend/components/Course/InstructorQueuePage/QueueFormFields.tsx
@@ -181,7 +181,7 @@ const QueueFormFields = ({
 
     return (
         <>
-            <Form.Field>
+            <Form.Field required>
                 <label htmlFor="form-name">Name</label>
                 <Form.Input
                     id="form-name"
@@ -199,7 +199,7 @@ const QueueFormFields = ({
                     {`Characters: ${nameCharCount}/100`}
                 </div>
             </Form.Field>
-            <Form.Field>
+            <Form.Field required>
                 <label htmlFor="form-desc">Description</label>
                 <Form.TextArea
                     id="form-desc"
@@ -410,6 +410,11 @@ const QueueFormFields = ({
                             width={2}
                             size="mini"
                             type="number"
+                            onKeyPress={(event) => {
+                                if (!/[0-9]/.test(event.key)) {
+                                    event.preventDefault();
+                                }
+                            }}
                             min="1"
                             id="timer-questions"
                             error={!validQuestionTime}

diff --git a/frontend/types.tsx b/frontend/types.tsx
@@ -104,15 +104,6 @@ export type Queue = BaseQueue &
         }
     >;
 
-// export type Queue =
-//     | (BaseQueue & { rateLimitEnabled: false })
-//     | (BaseQueue & {
-//           rateLimitEnabled: true;
-//           rateLimitLength: number;
-//           rateLimitQuestions: number;
-//           rateLimitMinutes: number;
-//       });
-
 // "ASKED" "WITHDRAWN" "ACTIVE" "REJECTED" "ANSWERED"
 export enum QuestionStatus {
     ASKED = "ASKED",