Adding TA Timers #322
Merged
Adding TA Timers #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielxue
approved these changes
Oct 25, 2024
frontend/types.tsx
Outdated
| } | ||
| >; | ||
|
|
||
| // export type Queue = |
| return ( | ||
| <> | ||
| <Form.Field> | ||
| <label htmlFor="form-name">Name</label> |
There was a problem hiding this comment.
Mark required fields as required.
| // Play a sound effect when hit zero (once) | ||
| useEffect(() => { | ||
| if (minutes + seconds === 0) { | ||
| if (!checkPermissions()) |
There was a problem hiding this comment.
Make sure null behavior is consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a countdown timer setting to Queues. With this setting enabled, every question will contain a countdown from when the Staff starts answering the question. This countdown can be configured to a time suitable for that course/queue. At 0:00, a sound effect is played + notification, and the time continues into negatives. This signifies it is time for the TA to move on to a new student.
The two separate Queue Forms (Creating and Updating) have been centralized into one component and separate parent components to allow the forms to differ if needed. Also created a better system for optional flags for the Queue Type to allow it to be easier to add more beyond Rate Limits.
Backend - Added 2 new fields to Queue to handle timer settings.