🌉 extend pre-commit rules

.pre-commit-config.yaml

@@ -31,4 +31,6 @@ repos:
           --warn-redundant-casts,
           --no-implicit-optional,
           --strict-optional,
-        ]
+          --warn-unused-ignores,
+          --disallow-incomplete-defs,
+        ]

backend/setup.cfg

@@ -3,6 +3,7 @@ max-line-length = 100
 exclude = .venv, migrations
 inline-quotes = double
 ignore = E203, W503, E704
+extend-select = F841, F401
 
 [isort]
 default_section = THIRDPARTY

backend/sublet/admin.py

@@ -6,9 +6,7 @@
 
 class SubletAdmin(admin.ModelAdmin):
     def image_tag(self, instance: Sublet) -> SafeText:
-        images = [
-            '<img src="%s" height="150" />' for image in instance.images.all()  # type: ignore
-        ]
+        images = ['<img src="%s" height="150" />' for image in instance.images.all()]
         return mark_safe("<br>".join(images))
 
     image_tag.short_description = "Sublet Images"  # type: ignore[attr-defined]

backend/sublet/models.py

@@ -1,5 +1,6 @@
 from django.contrib.auth import get_user_model
 from django.db import models
+from django.db.models import QuerySet
 from phonenumber_field.modelfields import PhoneNumberField
 
 
@@ -59,6 +60,8 @@ class Sublet(models.Model):
     start_date: models.DateField = models.DateField()
     end_date: models.DateField = models.DateField()
 
+    images: QuerySet
+
     def __str__(self) -> str:
         return f"{self.title} by {self.subletter}"
 

backend/tests/gsr_booking/test_gsr_booking.py

@@ -18,7 +18,7 @@ def setUp(self) -> None:
 
         self.group = Group.objects.create(owner=self.user1, name="g1", color="blue")
         self.group.members.add(self.user1)
-        memship = self.group.memberships.all()[0]  # type: ignore
+        memship = self.group.memberships.all()[0]
         memship.accepted = True
         memship.save()
         self.client: APIClient = APIClient()

backend/tests/sublet/test_sublets.py

@@ -260,9 +260,11 @@ def test_create_image(self) -> None:
                 f"/sublet/properties/{str(self.test_sublet1.id)}/images/", {"images": image}
             )
             self.assertEqual(response.status_code, 201)
-            images = Sublet.objects.get(id=self.test_sublet1.id).images.all()  # type: ignore
+            images = Sublet.objects.get(id=self.test_sublet1.id).images.all()
             self.assertTrue(images.exists())
-            self.assertEqual(self.test_sublet1.id, images.first().sublet.id)
+            first_image = images.first()
+            assert first_image is not None
+            self.assertEqual(self.test_sublet1.id, first_image.sublet.id)
 
     def test_create_delete_images(self) -> None:
         with open("tests/sublet/mock_image.jpg", "rb") as image:
@@ -273,11 +275,13 @@ def test_create_delete_images(self) -> None:
                     "multipart",
                 )
                 self.assertEqual(response.status_code, 201)
-                images = Sublet.objects.get(id=self.test_sublet1.id).images.all()  # type: ignore
-                image_id1 = images.first().id
+                images = Sublet.objects.get(id=self.test_sublet1.id).images.all()
+                first_image = images.first()
+                assert first_image is not None
+                image_id1 = first_image.id
                 self.assertTrue(images.exists())
                 self.assertEqual(2, images.count())
-                self.assertEqual(self.test_sublet1.id, images.first().sublet.id)
+                self.assertEqual(self.test_sublet1.id, first_image.sublet.id)
                 response = self.client.delete(f"/sublet/properties/images/{image_id1}/")
                 self.assertEqual(response.status_code, 204)
                 self.assertFalse(SubletImage.objects.filter(id=image_id1).exists())