Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe check JSON for checking Wharton #199

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Safe check JSON for checking Wharton #199

merged 2 commits into from
Sep 14, 2023

Conversation

judtinzhang
Copy link
Member

No description provided.

vcai122
vcai122 reviewed Sep 12, 2023
View reviewed changes
backend/gsr_booking/models.py
if response.status_code != 200:
return None

res_json = response.json()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return res_json.get("type") == "whartonMBA" or res_json.get("type") == "whartonUGR"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@judtinzhang judtinzhang merged commit 6bed369 into master Sep 14, 2023
7 checks passed
@judtinzhang judtinzhang deleted the judtin/gsr-check-wharton-json-fix branch September 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcai122 vcai122 vcai122 approved these changes

@tuneerroy tuneerroy Awaiting requested review from tuneerroy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judtinzhang @vcai122