Updated models.py #316
Updated models.py #316
Conversation
backend/market/models.py
Outdated
| User, through=Offer, related_name="sublets_offered", blank=True | ||
| class Item(models.Model): | ||
| seller = models.ForeignKey(User, on_delete=models.CASCADE) | ||
| tags = models.ManyToManyField(Tag, related_name="items", blank=True) |
There was a problem hiding this comment.
we don't need to specify related_name for most things unless there are multiple relationships
There was a problem hiding this comment.
If we don't specify related_name, django automatically generates a related_name right?
Also, do you mean we don't need to specify related_name for most things unless there are multiple relationships with the same model in a model?
There was a problem hiding this comment.
Yes, django automatically generates it. For the most part we only specify it if there is a strong reason to, one example is
if model A has
- goodBs = many to many to B
- badBs = many to many to B
Then we have to name the related_name specifically, so if we are on B looking at A we know which one we are talking about
|
|
||
| class Sublet(models.Model): | ||
| item = models.OneToOneField(Item, on_delete=models.CASCADE, related_name="sublet") | ||
| address = models.CharField(max_length=255) |
There was a problem hiding this comment.
Let's keep the same requirements for the model and same model fields.
There was a problem hiding this comment.
What do you mean by this? Are you asking me to remove related_name again?
| image = models.ImageField(upload_to="sublet/images") | ||
| class ItemImage(models.Model): | ||
| item = models.ForeignKey(Item, on_delete=models.CASCADE, related_name="images") | ||
| image = models.ImageField(upload_to="marketplace/images") |
There was a problem hiding this comment.
add a TODO here so we are reminded to verify this in production
There was a problem hiding this comment.
What exactly do you want us to verify? Is it the image routes?
So i can leave a more specific TODO
There was a problem hiding this comment.
make sure that this s3 bucket exists/if we need to make it manually or django will make it for us
backend/market/models.py
Outdated
|
|
||
|
|
||
| class Amenity(models.Model): | ||
| class Category(models.TextChoices): |
There was a problem hiding this comment.
Let's make this an actual model. That way I can add more categories on admin site.
|
Thanks for the feedback! |
There was a problem hiding this comment.
I looked at the models again but just skimmed the serializers.
I noticed some comments were unaddressed, I think a good system would be if you thumbs up the ones that are addressed (and I can verify and close the conversation). That way we know whats left to address.
backend/market/models.py
Outdated
|
|
||
| user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="offers_made") | ||
| sublet = models.ForeignKey("Sublet", on_delete=models.CASCADE, related_name="offers") | ||
| user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="offers_made_market") |
There was a problem hiding this comment.
are these _market because sublet exists? If so let's make a note to fix this after we delete sublet stuff
There was a problem hiding this comment.
I'll just remove related_name since there's only one ForeignKey to User in Offer.
backend/market/models.py
Outdated
|
|
||
|
|
||
| class Amenity(models.Model): | ||
| class Category(models.Model): | ||
| ''' |
There was a problem hiding this comment.
nit: remove this comment. feel free to post it in our slack chat or smth if u want to keep it around somewhere but lets not have dead code
There was a problem hiding this comment.
I kept it in so we remember which Categories to create when deploying the app. But yeah keeping it in Slack will be cleaner.
No description provided.