Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature branch deploy #142

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

Conversation

joyliu-q
Copy link
Contributor

@joyliu-q joyliu-q commented Jun 20, 2022

Doing it on a super simple react app to test it out.

TODO

  • Add branch protection rule against feat/ so randoms can't open a feature branch and deploy vulnerable code.
  • Design TODO: figure out good alternative to adding a message that says "Successfully deployed feature branch!" - Considerations thread
  • Test PR merge
  • Test PR close

Demo: https://pr-142.pennlabs.org/

@joyliu-q joyliu-q changed the title Add feature branch deploy (hopefully it works lol) Add feature branch deploy Jun 20, 2022
@joyliu-q joyliu-q marked this pull request as draft June 20, 2022 19:03
@github-actions
Copy link

Successfully deployed feature branch!

@github-actions
Copy link

Successfully deployed feature branch!

@joyliu-q
Copy link
Contributor Author

joyliu-q commented Jun 28, 2022

Oh wait, it should probably not say "Successfully deployed feature branch" every single time you add changes. That might get spammy on large feature branches that get pushed a bunch of small commits.

Considerations thread: pennlabs/infrastructure#98 (comment)

@github-actions
Copy link

Successfully deployed feature branch!

@github-actions
Copy link

Successfully deployed feature branch to:
pr-142-pennlabs.org

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Deployment preview for commit 8880982aa53727b3ac9e876d1416f2421499df74 ready at:
pr-142.pennlabs.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant