Skip to content

Commit

Permalink
Fix passing of secrets for integration tests (microsoft#680)
Browse files Browse the repository at this point in the history
### Motivation and Context
Secrets are not being passed properly in integration test workflow

### Description
Pass secrets properly

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
  • Loading branch information
glahaye authored Nov 30, 2023
1 parent 3f13273 commit 9547606
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/copilot-run-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ jobs:
- name: Run integration tests
env:
BaseServerUrl: "https://${{inputs.BACKEND_HOST}}.azurewebsites.net/"
Authority: "https://login.microsoftonline.com/${{secrets.COPILOT_CHAT_TEST_TENANT_ID}}"
TenantID: ${{secrets.COPILOT_CHAT_TEST_TENANT_ID}}
ClientID: ${{secrets.COPILOT_CHAT_TEST_APP_AAD_WEBAPP_CLIENT_ID}}
BackendClientID: ${{secrets.COPILOT_CHAT_TEST_APP_AAD_WEBAPI_CLIENT_ID}}
Username: ${{secrets.COPILOT_CHAT_TEST_USER_ACCOUNT1}}
Password: ${{secrets.COPILOT_CHAT_TEST_USER_PASSWORD1}}
Scopes: "openid, offline_access, profile, api://${{secrets.COPILOT_CHAT_TEST_APP_AAD_WEBAPI_CLIENT_ID}}/access_as_user"
run: dotnet test --logger trx
run: dotnet test --logger trx -e Authority="https://login.microsoftonline.com/$env:TenantID" -e Scopes="openid, offline_access, profile, api://$env:BackendClientID/access_as_user"

0 comments on commit 9547606

Please sign in to comment.