Reintroduce Rspec cops removed, add dev dependencies to gemspec, add …

…rubocop-rspec
pennylane-hq · Oct 26, 2023 · ba479a4 · ba479a4
1 parent 1ccf268
commit ba479a4
Show file tree

Hide file tree

Showing 4 changed files with 77 additions and 17 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,5 +1,7 @@
 ---
 
+require: rubocop-rspec
+
 Layout/BlockAlignment:
   EnforcedStyleAlignWith: start_of_block
 
@@ -110,6 +112,47 @@ Naming/InclusiveLanguage:
 Naming/VariableNumber:
   Enabled: false
 
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/ExampleWording:
+  DisallowedExamples:
+  - works
+  - does not work
+  - works as expected
+  - does something
+  - succeeds
+
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/InstanceVariable:
+  Enabled: true
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/MessageChain:
+  Enabled: true
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 8
+
+RSpec/Pending:
+  Enabled: true
+
+RSpec/StubbedMock:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Enabled: true
+
 Style/ArgumentsForwarding:
   Enabled: false
 

diff --git a/Gemfile b/Gemfile
@@ -5,12 +5,15 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 ruby '3.2.2'
 
-# License
-gem 'license_finder', require: false
+group :development do
+  # License
+  gem 'license_finder', require: false
 
-# Linting
-gem 'ruboclean', require: false
-gem 'rubocop', require: false
+  # Testing
+  gem 'rspec'
 
-# Testing
-gem 'rspec'
+  # Linting
+  gem 'ruboclean', require: false
+  gem 'rubocop', require: false
+  gem 'rubocop-rspec', require: false
+end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -47,6 +47,14 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.29.0)
       parser (>= 3.2.1.0)
+    rubocop-capybara (2.19.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.24.0)
+      rubocop (~> 1.33)
+    rubocop-rspec (2.24.1)
+      rubocop (~> 1.33)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
     rubyzip (2.3.2)
     thor (1.3.0)
@@ -64,6 +72,7 @@ DEPENDENCIES
   rspec
   ruboclean
   rubocop
+  rubocop-rspec
 
 RUBY VERSION
    ruby 3.2.2p53

diff --git a/cfonb.gemspec b/cfonb.gemspec
@@ -1,14 +1,19 @@
 # frozen_string_literal: true
 
 Gem::Specification.new do |s|
-  s.name                  = 'cfonb'
-  s.version               = '0.0.4'
-  s.required_ruby_version = '>= 3.2.2'
-  s.summary               = 'CFONB parser'
-  s.description           = 'An easy to use CFONB format parser'
-  s.authors               = ['Johan Le Bray', 'Frantisek Rokusek']
-  s.email                 = ''
-  s.files                 = Dir['{lib,spec}/**/*.rb']
-  s.homepage              = 'https://github.com/pennylane-hq/cfonb'
-  s.license               = 'MIT'
+  s.name                       = 'cfonb'
+  s.version                    = '0.0.4'
+  s.required_ruby_version      = '>= 3.2.2'
+  s.summary                    = 'CFONB parser'
+  s.description                = 'An easy to use CFONB format parser'
+  s.authors                    = ['Johan Le Bray', 'Frantisek Rokusek']
+  s.email                      = ''
+  s.files                      = Dir['{lib,spec}/**/*.rb']
+  s.homepage                   = 'https://github.com/pennylane-hq/cfonb'
+  s.license                    = 'MIT'
+  s.add_development_dependency('license_finder')
+  s.add_development_dependency('rspec')
+  s.add_development_dependency('ruboclean')
+  s.add_development_dependency('rubocop')
+  s.add_development_dependency('rubocop-rspec')
 end