-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exchange_rate
to operation
#12
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
90787c3
Add `exchange_rate` to operation
vnovitskyi 1f7b6b9
Add `exchange_rate` to operation
vnovitskyi 4c26d80
Fix code and specs
vnovitskyi b5ec726
Add `exchange_rate_scale`
vnovitskyi 67b38de
Merge branch 'master' into vn/add_exchange_rate
vnovitskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -5,7 +5,7 @@ | |||||||||||
module CFONB | ||||||||||||
module OperationDetail | ||||||||||||
class MMO | ||||||||||||
ATTRIBUTES = %i[original_currency original_amount].freeze | ||||||||||||
ATTRIBUTES = %i[original_currency original_amount exchange_rate].freeze | ||||||||||||
|
||||||||||||
def self.apply(operation, line) | ||||||||||||
operation.original_currency = line.detail[0..2] | ||||||||||||
|
@@ -14,6 +14,8 @@ def self.apply(operation, line) | |||||||||||
sign = operation.amount <=> 0 # the detail amount is unsigned | ||||||||||||
|
||||||||||||
operation.original_amount = sign * BigDecimal(line.detail[4..17]) / (10**scale) | ||||||||||||
exchange_rate_value = line.detail[26..29] | ||||||||||||
operation.exchange_rate = BigDecimal(exchange_rate_value) / 1000 if exchange_rate_value | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we are missing the scale of the exchange rate also
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @frantisekrokusek make sense. thank |
||||||||||||
end | ||||||||||||
|
||||||||||||
CFONB::OperationDetail.register('MMO', self) | ||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can still be wrong but ok to keep it like that for now